Horton

Re: Add os_page_num to pg_buffercache

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Tomas Vondra <tomas@vondra.me>
Cc: Nathan Bossart <nathandbossart@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-07-02T10:13:34Z
Lists: pgsql-hackers

Attachments

Hi,

On Wed, Jul 02, 2025 at 06:39:25AM +0000, Bertrand Drouvot wrote:
> Hi,
> 
> On Tue, Jul 01, 2025 at 07:46:30PM +0200, Tomas Vondra wrote:
> > On 7/1/25 19:20, Bertrand Drouvot wrote:
> > > Now it's just a matter of extracting the necessary pieces from pg_buffercache_numa_pages()
> > > so that:
> > > 
> > > * the new view could make use of it
> > > * the maintenance burden should be low (thanks to code dedeuplication)
> > > * people that don't have access to a platform that supports libnuma can have
> > > access to this information
> > > 
> > 
> > +1
> 
> PFA attached v3 adding a new view and function to pg_buffercache (both named
> pg_buffercache_os_pages). I think the names are fine but not 100% convinced 
> though.

Rebased due to 8eede2c7200.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. pg_buffercache: Add pg_buffercache_os_pages

  2. doc: Fix style of description for pg_buffercache_numa.os_page_num

  3. Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions.

  4. pg_walsummary: Improve stability of test checking statistics