Re: [PATCH] Split varlena.c into varlena.c and bytea.c

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Development <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter@eisentraut.org>
Date: 2025-07-02T00:55:22Z
Lists: pgsql-hackers
On Wed, Jun 18, 2025 at 02:13:27PM +0900, Michael Paquier wrote:
> v3 seems sensible here.  Thanks for the updated patch.

I did a new pass over that.  All the code blocks moved to the new file
are identical.  However, it is really easy to miss the change in
bytea_string_agg_transfn() with the removal of makeStringAggState().
This was mentioned upthread but for somebody who reads only the git
diffs that could be surprising.

I have added a note about that in the commit message, for clarity,
and applied the result.
--
Michael

Commits

  1. Move code for the bytea data type from varlena.c to new bytea.c