Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>

To: Aleksander Alekseev <aleksander@timescale.com>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>, Michael Paquier <michael@paquier.xyz>

Date: 2025-06-20T14:14:17Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pgindent: improve formatting of multiline comments.
- 60f9467c3834 19 (unreleased) landed
Adjust style of some debugging macros.
- ba1e14134a77 19 (unreleased) landed
Fix a couple of comments.
- 123661427b97 19 (unreleased) landed
Add IGNORE NULLS/RESPECT NULLS option to Window functions.
- 25a30bbd4235 19 (unreleased) cited
Split WaitEventSet functions to separate source file
- 393e0d231405 18.0 cited

On Fri, Jun 20, 2025 at 05:01:41PM +0300, Aleksander Alekseev wrote:
> Hi,
> 
> > Given the quality of BSD indent code, I have _always_ found it easier to
> > modify pgindent.  ;-
> 
> :D Initially I thought that the problem was simple enough to solve it
> in C, but this turned out not to be true.

I always found it ironic that a tool designed to make source code easier
to understand like BSD indent is so hard to understand.  Its use of
short variable names alone is confusing.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.