Horton

Thread

Commits

  1. pgxs.mk: remove unreachable rule for deleting regress.def.

  1. Removing rm regress.def

    Christoph Berg <myon@debian.org> — 2025-06-20T12:19:57Z

    pgxs.mk is cleaning up a file "regress.def" if PORTNAME=win, but the
only reference to that file I could find is in the original commit
from 1999 adding that "rm" rule (and several commits moving the rule
around later).

Given that the PORTNAME is wrong (should be win32), it's probably safe
to just delete the rule.

Christoph

  2. Re: Removing rm regress.def

    Tom Lane <tgl@sss.pgh.pa.us> — 2025-06-20T15:20:43Z

    Christoph Berg <myon@debian.org> writes:
> pgxs.mk is cleaning up a file "regress.def" if PORTNAME=win, but the
> only reference to that file I could find is in the original commit
> from 1999 adding that "rm" rule (and several commits moving the rule
> around later).

> Given that the PORTNAME is wrong (should be win32), it's probably safe
> to just delete the rule.

Yeah, seems quite bogus.  It's harmless though, so I don't
see a need to back-patch, do you?

			regards, tom lane

  3. Re: Removing rm regress.def

    Christoph Berg <myon@debian.org> — 2025-06-20T16:00:38Z

    Re: Tom Lane
> Yeah, seems quite bogus.  It's harmless though, so I don't
> see a need to back-patch, do you?

Other than it being confusing, it doesn't hurt.

Christoph

  4. Re: Removing rm regress.def

    Tom Lane <tgl@sss.pgh.pa.us> — 2025-06-20T16:35:46Z

    Christoph Berg <myon@debian.org> writes:
> Re: Tom Lane
>> Yeah, seems quite bogus.  It's harmless though, so I don't
>> see a need to back-patch, do you?

> Other than it being confusing, it doesn't hurt.

OK, applied to master only.

			regards, tom lane