Horton

Re: [PATCH] Split varlena.c into varlena.c and bytea.c

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Development <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter@eisentraut.org>
Date: 2025-06-18T05:13:27Z
Lists: pgsql-hackers 
On Mon, Jun 16, 2025 at 01:33:20PM +0300, Aleksander Alekseev wrote:
> Thanks, fixed. clangd complained that utils/fmgroids.h is not going to
> be used, as it complained about funcapi.h before. So I choose not to
> include fmgroids.h.

v3 seems sensible here.  Thanks for the updated patch.

/* text_name()
 * Converts a text type to a Name type.
 */

Not related to this patch, sorry for the regression, just noticed
a nit while looking at the diffs of what you have here..  This one, as
well as name_text(), uses a comment block that is inconsistent with
the format we have in the tree.  It's a bit surprising that pgindent
is not picking up that.
--
Michael

Commits

  1. Move code for the bytea data type from varlena.c to new bytea.c