Horton

Re: [PATCH] Add tests for binaryheap.c

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-06-26T20:46:50Z
Lists: pgsql-hackers 
On Thu, Jun 26, 2025 at 06:16:10PM +0300, Aleksander Alekseev wrote:
> The proposed patch adds tests for binaryheap.c. This is similar to our
> tests for RB-trees in test_rbtree.c.

Adding some tests here seems like a good idea.

I'm not sure I see much point in testing both min-heaps and max-heaps.  The
only difference between the two is in the comparator, so IMHO the extra
tests really only serve to test the test comparator.

-- 
nathan

Commits

  1. Add a test harness for the binary heap code.