Re: queryId constant squashing does not support prepared statements

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Sami Imseih <samimseih@gmail.com>

Cc: Álvaro Herrera <alvherre@kurilemu.de>, Dmitry Dolgov <9erthalion6@gmail.com>, Junwang Zhao <zhjwpku@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-05-29T02:30:12Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix typo in comment
- a3994ec6acb2 18.0 landed
Make query jumbling also squash PARAM_EXTERN params
- c2da1a5d6325 18.0 landed
Fix squashing algorithm for query texts
- 0f65f3eec478 18.0 landed
pg_stat_statements: Fix parameter number gaps in normalized queries
- 3c03b8cd7979 13.22 landed
- 8a1459f62ad1 14.19 landed
- 130300a15407 15.14 landed
- 7e8b44f4e0e6 16.10 landed
- 290e8ab32ac5 17.6 landed
- 35a428f30b15 18.0 landed

On Wed, May 28, 2025 at 04:05:03PM -0500, Sami Imseih wrote:
> That's my mistake. I added a new file called normalize.sql to test
> specific normalization scenarios. Added in v7

Thanks.  I was not sure that a new file was worth having for these
tests, knowing that select.sql has similar coverage.  I have grouped
the new tests into select.sql at the end, and added a few more
scenarios for extended queries with \bindin extended.sql, where I've
reproduced the same issue while playing with external parameters.
Applied the result down to v13, down to where the problem exists for
supported branches.

I still need to review the rest of the patch series..
--
Michael