Horton
Menu

Re: SIMILAR TO expressions translate wildcards where they shouldn't

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-bugs@lists.postgresql.org
Date: 2025-05-28T00:15:33Z
Lists: pgsql-bugs 
On Wed, May 28, 2025 at 09:00:20AM +0900, Michael Paquier wrote:
> Nice trick that makes the test output much smaller.  I've used this
> idea and applied the fix down to v13 after a second lookup this
> morning.

And I've managed to miss that the case with an opening parenthesis
throws an error due to an unbalanced set of parentheses because the
regexp is processed when the query is written the way Tom has
mentioned.

Will fix in a bit after an extra round of check-world, sorry about
that..
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Adjust regex for test with opening parenthesis in character classes

  2. Fix conversion of SIMILAR TO regexes for character classes