Re: queryId constant squashing does not support prepared statements

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Dmitry Dolgov <9erthalion6@gmail.com>

Cc: Sami Imseih <samimseih@gmail.com>, Álvaro Herrera <alvherre@kurilemu.de>, Junwang Zhao <zhjwpku@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-05-24T00:17:14Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix typo in comment
- a3994ec6acb2 18.0 landed
Make query jumbling also squash PARAM_EXTERN params
- c2da1a5d6325 18.0 landed
Fix squashing algorithm for query texts
- 0f65f3eec478 18.0 landed
pg_stat_statements: Fix parameter number gaps in normalized queries
- 3c03b8cd7979 13.22 landed
- 8a1459f62ad1 14.19 landed
- 130300a15407 15.14 landed
- 7e8b44f4e0e6 16.10 landed
- 290e8ab32ac5 17.6 landed
- 35a428f30b15 18.0 landed

On Fri, May 23, 2025 at 04:29:45PM +0200, Dmitry Dolgov wrote:
> I think it's better to recursively call IsSquashableConst on the nested
> expression (arg or args for FuncExpr). Something like that was done in
> the original patch version and was concidered too much at that time, but
> since it looks like all the past concerns are lifted, why not. Do not
> forget check_stack_depth.

AFAIK, we have already a couple of check_stack_depth() calls during
some node transformations after-parsing.  At this level of the code
that would be a new thing..
--
Michael