Horton
Menu

Re: C11 / VS 2019

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-06-03T04:51:06Z
Lists: pgsql-hackers 
On Mon, Jun 02, 2025 at 08:52:00AM -0500, Nathan Bossart wrote:
> On Mon, Jun 02, 2025 at 05:44:12AM +0200, Peter Eisentraut wrote:
>> Summary:
>> 1. require VS 2019
>> 2. use C11
>> 
>> Thoughts?
> 
> +1

+1 to move on for both of these.  I got convinced about the benefits
of C11 and the simplifications we could get from it in the Postgres
code base during your presentation at pgconf.dev.

Dropping VS 2015 and going up to VS 2019 brings other benefits,
__VA_ARGS__ coming in mind.  I am wondering what's the state of
locales, actually.  We've had some pain with VS 2015 as we lacked
locale_name in _locale_t, for example.  That may be worth a second
look to see if some simplifications can happen in this area.  I don't
think so at quick glance through the VS docs, unfortunately, but I may
be wrong, of course..
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Raise C requirement to C11

  2. meson: Move C99 test earlier

  3. Enable MSVC conforming preprocessor

  4. Make parseNodeString() C idiom compatible with Visual Studio 2015.