Re: Add comment explaining why queryid is int64 in pg_stat_statements

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: David Rowley <dgrowleyml@gmail.com>

Cc: Lukas Fittl <lukas@fittl.com>, Peter Eisentraut <peter@eisentraut.org>, Shaik Mohammad Mujeeb <mujeeb.sk@zohocorp.com>, ilyaevdokimov <ilya.evdokimov@tantorlabs.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, mujeebskdev <mujeeb.sk.dev@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-05-20T06:38:13Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Change internal plan ID type from uint64 to int64
- e050af28686e 18.0 landed
Change internal queryid type from uint64 to int64
- c3eda50b0648 18.0 landed
pg_stat_statements: Widen query IDs from 32 bits to 64 bits.
- cff440d36869 11.0 cited

Attachments

0001-Change-internal-queryid-type-to-int64.patch (text/x-diff) patch 0001
0002-Change-type-of-plan-IDs-from-uint64-to-int64.patch (text/x-diff) patch 0002

On Tue, May 20, 2025 at 05:51:51PM +1200, David Rowley wrote:
> Given the planId stuff is new and has the same issue, I think that
> pushes me towards thinking now is better than later for fixing both.
> 
> I'm happy to adjust my patch unless you've started working on it already.

Here you go with the attached, to-be-applied on top of your own patch.
--
Michael