Horton
Menu

Re: Regression in statement locations

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: David Steele <david@pgbackrest.org>, Pg Hackers <pgsql-hackers@postgresql.org>, Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>, jian he <jian.universality@gmail.com>
Date: 2025-05-19T23:38:47Z
Lists: pgsql-hackers 
On Mon, May 19, 2025 at 05:10:14PM -0500, Sami Imseih wrote:
> I am still not sure why this is the case, but wanted to share this
> for now.

Hmm.  Something seems to not be compiling well for the final query of
a stmtmulti in gram.y with updateRawStmtEnd(), as we rely on the
position of the semicolon to decide what the stmt_len should be with
multiple querues.  We don't set the stmt_len without the semicolon,
causing pgss to reuse the full query length when storing the entry of
the last query.

With the semicolon in place, stmt_len gets set for the last query of
the string.  Still digging more..
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix regression with location calculation of nested statements