Re: Addition of %b/backend_type in log_line_prefix of TAP test logs
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Fujii Masao <masao.fujii@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-05-21T23:50:04Z
Lists: pgsql-hackers
On Wed, May 21, 2025 at 09:24:26AM +0200, Daniel Gustafsson wrote: > Agreed, and +1 on the change in general. Another point perhaps worth considering after a second look: how about pg_ci_base.conf? We have the following line there, exposing this configuration with TEMP_CONFIG: src/tools/ci/pg_ci_base.conf:log_line_prefix = '%m [%p][%b] %q[%a][%v:%x] ' The two other ones are: src/test/perl/PostgreSQL/Test/Cluster.pm: '%m [%p] %q%a ' src/test/regress/pg_regress.c: '%m %b[%p] %q%a ' Perhaps it would be better to apply the same configuration as the CI by default at the end? The difference is that the CI exposes [virtual] XIDs. I've never used this information for debugging, but that may be worth considering for consistency? This would make easier checks across the buildfarm, the CI or local machines when looking for differences in the logs with the same tests. (I was incorrect previously about CI not using backend_type upthread.) -- Michael
Commits
-
Align log_line_prefix in CI and TAP tests with pg_regress.c
- 5ba00e175a4e 19 (unreleased) landed