Horton

Thread

Commits

  1. pg_dumpall: Add --sequence-data.

  2. pg_dump: Add --sequence-data.

  1. add --sequence-data to pg_dumpall

    Nathan Bossart <nathandbossart@gmail.com> — 2025-04-29T20:55:08Z

    I noticed that I forgot to add --sequence-data to pg_dumpall in commit
9c49f0e, which added the same option to pg_dump.  This option is primarily
intended for use by pg_upgrade, so we will need it if/when we teach
pg_upgrade to use pg_dumpall to dump the databases.  (Right now pg_upgrade
directly calls pg_dump on each database.)

Assuming we want this patch, should we apply it to v18?  It's arguably an
oversight in the pg_dump --sequence-data commit, and pg_dumpall will just
pass the option through to pg_dump, but otherwise there's not a really
strong reason it can't wait.

-- 
nathan

  2. Re: add --sequence-data to pg_dumpall

    Michael Paquier <michael@paquier.xyz> — 2025-04-30T00:29:59Z

    On Tue, Apr 29, 2025 at 03:55:08PM -0500, Nathan Bossart wrote:
> I noticed that I forgot to add --sequence-data to pg_dumpall in commit
> 9c49f0e, which added the same option to pg_dump.  This option is primarily
> intended for use by pg_upgrade, so we will need it if/when we teach
> pg_upgrade to use pg_dumpall to dump the databases.  (Right now pg_upgrade
> directly calls pg_dump on each database.)
> 
> Assuming we want this patch, should we apply it to v18?  It's arguably an
> oversight in the pg_dump --sequence-data commit, and pg_dumpall will just
> pass the option through to pg_dump, but otherwise there's not a really
> strong reason it can't wait.

This reminds me of, that fixed a similar defect in pg_dumpall
following the addition of an option in pg_dump where the former was
forgotten:
https://www.postgresql.org/message-id/YKHC%2BqCJvzCRVCpY%40paquier.xyz

I agree with applying that to v18 now and treat it as a defect rather
than wait for v19 and treat this patch as a new feature.  Bonus points
for the patch being straight-forward.
--
Michael

  3. Re: add --sequence-data to pg_dumpall

    Nathan Bossart <nathandbossart@gmail.com> — 2025-04-30T19:52:27Z

    On Wed, Apr 30, 2025 at 09:29:59AM +0900, Michael Paquier wrote:
> On Tue, Apr 29, 2025 at 03:55:08PM -0500, Nathan Bossart wrote:
>> Assuming we want this patch, should we apply it to v18?  It's arguably an
>> oversight in the pg_dump --sequence-data commit, and pg_dumpall will just
>> pass the option through to pg_dump, but otherwise there's not a really
>> strong reason it can't wait.
> 
> This reminds me of, that fixed a similar defect in pg_dumpall
> following the addition of an option in pg_dump where the former was
> forgotten:
> https://www.postgresql.org/message-id/YKHC%2BqCJvzCRVCpY%40paquier.xyz
> 
> I agree with applying that to v18 now and treat it as a defect rather
> than wait for v19 and treat this patch as a new feature.  Bonus points
> for the patch being straight-forward.

Since there's precedent, I'll plan on committing this in the next few days
unless someone objects.  I've added the rest of the RMT to this thread,
too, just in case.

-- 
nathan

  4. Re: add --sequence-data to pg_dumpall

    Nathan Bossart <nathandbossart@gmail.com> — 2025-05-06T16:39:33Z

    On Wed, Apr 30, 2025 at 02:52:27PM -0500, Nathan Bossart wrote:
> Since there's precedent, I'll plan on committing this in the next few days
> unless someone objects.  I've added the rest of the RMT to this thread,
> too, just in case.

I brought this up in the RMT meeting today, and everyone was fine with
committing it for v18.  I'll plan on doing so later this week.

-- 
nathan

  5. Re: add --sequence-data to pg_dumpall

    Nathan Bossart <nathandbossart@gmail.com> — 2025-05-07T18:41:57Z

    On Tue, May 06, 2025 at 11:39:33AM -0500, Nathan Bossart wrote:
> I brought this up in the RMT meeting today, and everyone was fine with
> committing it for v18.  I'll plan on doing so later this week.

Committed.

-- 
nathan