Horton
Menu

Re: allow changing autovacuum_max_workers without restarting

Nathan Bossart <nathandbossart@gmail.com>

View thread
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>, Andres Freund <andres@anarazel.de>, pgsql-hackers@lists.postgresql.org, "Imseih (AWS), Sami" <simseih@amazon.com>, Justin Pryzby <pryzby@telsasoft.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2025-04-29T17:24:06Z
Lists: pgsql-hackers 
On Tue, Apr 29, 2025 at 01:19:18PM -0400, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> On 28.04.25 16:41, Nathan Bossart wrote:
>>> However, weren't we considering reverting some of this stuff [0]?  I see
>>> that sawshark is now choosing max_connections = 40 and
>>> autovacuum_worker_slots = 6, and since there are no other apparent related
>>> buildfarm failures, I'm assuming that nobody else is testing the 60
>>> semaphores case anymore.
>>> 
>>> [0] https://postgr.es/m/618497.1742347456%40sss.pgh.pa.us
> 
>> (I don't have any thoughts on this.)
> 
> Andres seemed lukewarm about reverting 38da05346 or 6d0154196, so
> I left it be for the moment.  But I still feel the argument is good
> that "these will do little except confuse future hackers".  Barring
> objection, I'll go revert them.

+1, I almost threatened the same but wasn't totally positive where the
discussion stood.

-- 
nathan

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Give up on running with NetBSD/OpenBSD's default semaphore settings.

  2. initdb: Do not report default autovacuum_worker_slots.

  3. Lower default value of autovacuum_worker_slots in initdb as needed.

  4. Allow changing autovacuum_max_workers without restarting.

  5. Reserve a PGPROC slot and semaphore for the slotsync worker process.

  6. Make archiver process an auxiliary process.

  7. Correct the formulas for System V IPC parameters SEMMNI and SEMMNS in docs.