Re: queryId constant squashing does not support prepared statements

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Junwang Zhao <zhjwpku@gmail.com>

Cc: Dmitry Dolgov <9erthalion6@gmail.com>, Sami Imseih <samimseih@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-05-09T05:35:33Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix typo in comment
- a3994ec6acb2 18.0 landed
Make query jumbling also squash PARAM_EXTERN params
- c2da1a5d6325 18.0 landed
Fix squashing algorithm for query texts
- 0f65f3eec478 18.0 landed
pg_stat_statements: Fix parameter number gaps in normalized queries
- 3c03b8cd7979 13.22 landed
- 8a1459f62ad1 14.19 landed
- 130300a15407 15.14 landed
- 7e8b44f4e0e6 16.10 landed
- 290e8ab32ac5 17.6 landed
- 35a428f30b15 18.0 landed

On Fri, May 09, 2025 at 11:05:43AM +0800, Junwang Zhao wrote:
> Why not a location and a length, it should be more natural, it
> seems we use this convention in some existing nodes, like
> RawStmt, InsertStmt etc.

These are new concepts as of Postgres 18 (aka only on HEAD), chosen
mainly to match with the internals of pg_stat_statements as far as I
recall.  Doing the same here would not hurt, but it may be better
depending on the cases to rely on a start/end.  I suspect that
switching from one to the other should not change much the internal
squashing logic.
--
Michael