Horton

Re: Avoid circular header file dependency

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-04-26T08:31:32Z
Lists: pgsql-hackers

Attachments

Hi,

On Sat, Apr 26, 2025 at 04:42:56PM +0900, Michael Paquier wrote:
> This one is my fault,

I do feel guilty too...

> Splitting the values
> of the wait classes into their own header makes sense, but the header
> name wait_class_constants.h sounds a bit off.  Why not a simpler
> "wait_classes.h" that gets included by wait_event.h and
> wait_event_types.h?

Yeah, better. Done that way in the attached.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Remove circular #include's between wait_event.h and wait_event_types.h

  2. Remove circular #include's between plpython.h and plpy_util.h.