Horton
Menu

Re: [PATCH] Add tests for Bitmapset

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Greg Burd <greg@burd.me>, Ranier Vilela <ranier.vf@gmail.com>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-09T03:47:31Z
Lists: pgsql-hackers

Attachments

On Thu, Oct 09, 2025 at 04:35:55PM +1300, David Rowley wrote:
> On Thu, 9 Oct 2025 at 15:13, Michael Paquier <michael@paquier.xyz> wrote:
> > What do you think about the attached?
> 
> Thanks. Looks pretty good.
> 
> > + members = palloc(sizeof(int) * num_ops);
> 
> Any reason to pfree that and allocate that to the same size as it already was?

No reason.  We can shortcut that a bit.

> Wondering if the "members[pos] = members[--num_members];" is worth a
> short comment. Maybe something like: /* zap this member by moving the
> final array member into its place and shrinking the array by 1 */

Yes, a comment can be adapted here.  Sounds good to me.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Minor fixes for test_bitmapset.c

  2. test_bitmapset: Improve random function

  3. Add mem_exceeded_count column to pg_stat_replication_slots.

  4. Tidy-up unneeded NULL parameter checks from SQL function

  5. Remove check for NULL in STRICT function

  6. Fixes for comments in test_bitmapset

  7. Minor fixups of test_bitmapset.c

  8. test_bitmapset: Simplify code of the module

  9. test_bitmapset: Expand more the test coverage

  10. Fix compiler warnings in test_bitmapset

  11. Add a test module for Bitmapset