Re: Remove custom redundant full page write description from GIN

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Kirill Reshke <reshkekirill@gmail.com>

Cc: Andrey Borodin <x4mmm@yandex-team.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-10-08T05:14:06Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Improve description of some WAL records for GIN
- 138da727a174 19 (unreleased) landed
Add comment in ginxlog.h about block used with ginxlogInsertListPage
- 42c6b74d8928 19 (unreleased) landed
Remove block information from description of some WAL records for GIN
- 7072a8855e84 19 (unreleased) landed
Remove useless pointer update in ginxlog.c
- 3f431109dc63 19 (unreleased) landed

On Tue, Oct 07, 2025 at 02:08:02PM +0500, Kirill Reshke wrote:
> Turns out we already use XLogRecGetData in assignment:  char *rec =
> XLogRecGetData(record). But I still did alter v2 patch a bit,
> introducing new variable xlrec, to avoid clunky casts between char *
> and ginxlogUpdateMeta.

For UPDATE_META_PAGE, ntuples == 0 could also mean that we may show
a lot of invalid block numbers, as well, which feels a bit pointless.
I have switched that to check InvalidBlockNumber instead.

While reviewing the whole, I have noticed that rightlink was missing
for INSERT_LISTPAGE, as well as the right/left children pages for
SPLIT.  I have added this information, applied the result.  Thanks!
--
Michael