Re: Remove custom redundant full page write description from GIN

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Andrey Borodin <x4mmm@yandex-team.ru>

Cc: Kirill Reshke <reshkekirill@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-10-07T06:46:10Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Improve description of some WAL records for GIN
- 138da727a174 19 (unreleased) landed
Add comment in ginxlog.h about block used with ginxlogInsertListPage
- 42c6b74d8928 19 (unreleased) landed
Remove block information from description of some WAL records for GIN
- 7072a8855e84 19 (unreleased) landed
Remove useless pointer update in ginxlog.c
- 3f431109dc63 19 (unreleased) landed

On Wed, Oct 01, 2025 at 03:39:35PM +0900, Michael Paquier wrote:
> +                   int32       ntuples;
> +                   ntuples = ((ginxlogUpdateMeta *) rec)->ntuples;
> +                   appendStringInfo(buf, "ntuples: %d", ntuples);
> 
> In 0002.  We have a routine for this type of assignments:
> XLogRecGetBlockData().  Let's use it here for clarity.

This should be XLogRecGetData(), not XLogRecGetBlockData(), as the
data is assigned to the record.  My apologies for the mistake.
--
Michael