Re: Refactoring: Use soft error reporting for *_opt_error functions

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: jian he <jian.universality@gmail.com>

Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, Amul Sul <sulamul@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-10-06T02:18:17Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix two comments in numeric.c
- 0c7f10302820 19 (unreleased) landed
Switch some numeric-related functions to use soft error reporting
- 4246a977bad6 19 (unreleased) landed
Change pg_lsn_in_internal() to use soft error reporting
- ae453120085f 19 (unreleased) landed

On Mon, Oct 06, 2025 at 06:19:49AM +0800, jian he wrote:
> /*
>  * Internal version of int8_numeric() with support for soft error reporting.
>  */
> int64
> numeric_int8_safe(Numeric num, Node *escontext)
> 
> the above comment "int8_numeric" should be "numeric_int8"?

Yep.  The same is true about numeric_int4_safe() where int4_numeric()
is referenced.  Will fix, thanks.
--
Michael