Re: Remove obsolate comments from 047_checkpoint_physical_slot
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Alexander Korotkov <aekorotkov@gmail.com>
Date: 2025-09-25T07:59:41Z
Lists: pgsql-hackers
On Thu, Sep 25, 2025 at 09:32:40AM +0200, Daniel Gustafsson wrote: > On 25 Sep 2025, at 09:23, Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> wrote: >> Here USE_INJECTION_POINTS check is not needed. If the feature is disabled, >> the macro function would be ((void) name). IIUC, we are using the macro if if-branch >> exists. > > +1, that's not needed (and not used elsewhere in the code either). Yeah, let's remove that. Simplification in the backend code is the whole point of the double definition of the INJECTION_POINT() macro in injection_point.h. And the comments of the test 047 are indeed not required anymore. Good catch. If you want to go ahead and clean up all that, Daniel, please feel free. If not, I'm OK to pull the trigger on this one. -- Michael
Commits
-
Remove preprocessor guards from injection points
- efc26d17a7d4 18.1 landed
- 53a2246ddf9b 17.7 landed
- 0b3ce7878af7 19 (unreleased) landed
-
Fix comments in recovery tests
- d8f07dbb81a1 19 (unreleased) landed