Horton

Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Etsuro Fujita <etsuro.fujita@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, kristianlejao@gmail.com
Date: 2025-09-24T23:14:46Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch.

On Wed, Sep 24, 2025 at 09:45:26AM -0700, Masahiko Sawada wrote:
> On Wed, Sep 24, 2025 at 3:28 AM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
>> I took a quick glance at the patch.  My initial comment is: it only
>> includes the test case discussed here, but I think it's a good idea to
>> add more cases in it (that exercise code paths in
>> postgresRecheckForeignScan), as I mentioned upthread.  What do you
>> think about that?  If no objections, I'd like to update it to include
>> such cases.
> 
> +1 to add more test cases for the code paths in postgresRecheckForeignScan.

+1.  Would these be included in the same isolation test?  That may be
cleaner, especially as it seems like the EPQ re-evaluations should be
able to happen with the same schema as the one set up by the test.
--
Michael