Re: "openssl" should not be optional
Christoph Berg <myon@debian.org>
From: Christoph Berg <myon@debian.org>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-09-24T15:13:44Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Avoid warnings in tests when openssl binary isn't available
- f01c4eb4e901 17.7 landed
- bf5b26525b28 16.11 landed
- 7d129ba54e74 19 (unreleased) landed
- 150a1b328778 18.1 landed
Re: Daniel Gustafsson > Looking at this I was reminded that we already handle this by using a fallback > and the test worked all along. The message for this was quite poorly worded > though, and used a warning instead of a note. The attached will try to detect > openssl being missing before trying to run it, and will skip the warning > message if the fallback is used (which really isn't a warning in the first > place). Thanks, I just built the postgresql-18 again with this patch (and openssl not installed [*]). It passes fine now. In the meantime, I also got the report that postgresql-17 is not failing in that environment, so the problem is new in 18. > The ERROR in 003_sslinfo is intentional, we are testing that processing fails > by passing an invalid value. Ah, I was mentioning that in the original report because it only showed up in the failing log, but that's just because the non-failing build does not go scraping the test log files. That made the problem look bigger than it actually was. Thanks, Christoph [*] future builds will have openssl as build-dependency.