Re: Report bytes and transactions actually sent downtream

Hi,

On Fri, Oct 03, 2025 at 12:22:05PM +0530, Ashutosh Bapat wrote:
> Here's patchset addressing two issues:

Thanks for the patch update!

> I
> have added a note in documentation for plugin authors, warning them
> that this isn't expected.

What note are you referring to? (I'm failing to see it).

> I don't think it's worth adding complexity
> in code to support such a case unless we see a practical need for the
> same.

Sounds good.


> Issue 2: Once X + 2 is loaded, further statistics are accumulated on
> the top of statistics accumulated by version X. Attached patch fixes
> issue 2 by zero'ing out the stats when the plugin does not report the
> statistics.

+#define REPLSLOT_SET_TO_ZERO(fld) statent->fld = 0

It looks like that the associated "undef" is missing.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com