Horton
Menu

Re: [PATCH] Add tests for Bitmapset

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, Greg Burd <greg@burd.me>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-03T00:42:48Z
Lists: pgsql-hackers 
On Fri, Oct 03, 2025 at 12:36:57PM +1300, David Rowley wrote:
> I see test_random_operations() is also strict. Is it worth getting rid
> of the SQL NULL checks on the inputs there too? Aka, the attached.

Yes, this was not bothering me much.  Anyway, agreed about removing
these as well.  I cannot find an argument in favor of making the
function callable on NULL input with default values that are hardcoded
internally in the function.

Thanks, David and Daniel.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Minor fixes for test_bitmapset.c

  2. test_bitmapset: Improve random function

  3. Add mem_exceeded_count column to pg_stat_replication_slots.

  4. Tidy-up unneeded NULL parameter checks from SQL function

  5. Remove check for NULL in STRICT function

  6. Fixes for comments in test_bitmapset

  7. Minor fixups of test_bitmapset.c

  8. test_bitmapset: Simplify code of the module

  9. test_bitmapset: Expand more the test coverage

  10. Fix compiler warnings in test_bitmapset

  11. Add a test module for Bitmapset