Re: Remove PointerIsValid()

Nathan Bossart <nathandbossart@gmail.com>

From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-09-17T16:21:10Z
Lists: pgsql-hackers
On Wed, Sep 17, 2025 at 10:15:10AM -0400, Peter Geoghegan wrote:
> On Wed, Sep 17, 2025 at 1:21 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>> I think there is agreement that the PointerIsValid() macro is pretty
>> useless.  This patch proposes to remove it.  There have been a few
>> recent mini-discussions in other threads that appear to support this. [0][1]
> 
> I'm also in favor of removing it.
> 
>> There were the usual concerns about code churn and backpatching and so
>> on, but I think in the end the change is not that big and it's in pretty
>> boring positions.
> 
> I agree.

+1

-- 
nathan



Commits

  1. Remove PointerIsValid()