Re: [PATCH] Add tests for Bitmapset

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Masahiko Sawada <sawada.mshk@gmail.com>

Cc: Greg Burd <greg@burd.me>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Nathan Bossart <nathandbossart@gmail.com>, Robert Haas <robertmhaas@gmail.com>

Date: 2025-09-17T00:35:30Z

Lists: pgsql-hackers

On Tue, Sep 16, 2025 at 03:00:40PM -0700, Masahiko Sawada wrote:
> Thank you for updating the patch. It seems cfbot caught a regression
> test error[1] in a 32-bit build.

- bitmap_hash [1,3,5] |   49870778
+ bitmap_hash [1,3,5] | 1509752520

This one is able the hash value computation being not portable across
architectures.  I would just change these to be non-NULL, I guess.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Minor fixes for test_bitmapset.c
- 5142f0093e64 19 (unreleased) landed
test_bitmapset: Improve random function
- 9d46b86529e8 19 (unreleased) landed
Add mem_exceeded_count column to pg_stat_replication_slots.
- d3b6183dd988 19 (unreleased) landed
Tidy-up unneeded NULL parameter checks from SQL function
- a69b55cd4727 19 (unreleased) landed
Remove check for NULL in STRICT function
- 381f5cffae00 19 (unreleased) landed
Fixes for comments in test_bitmapset
- a1b064e4b226 19 (unreleased) landed
Minor fixups of test_bitmapset.c
- 3a6615806859 19 (unreleased) landed
test_bitmapset: Simplify code of the module
- 9952f6c05a40 19 (unreleased) landed
test_bitmapset: Expand more the test coverage
- 5668fff3c512 19 (unreleased) landed
Fix compiler warnings in test_bitmapset
- f83fe65f3fc1 19 (unreleased) landed
Add a test module for Bitmapset
- 00c3d87a5cab 19 (unreleased) landed