Horton

Re: [BUG] temporary file usage report with extended protocol and unnamed portals

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Mircea Cadariu <cadariu.mircea@gmail.com>, Frédéric Yhuel <frederic.yhuel@dalibo.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Benoit Lobréau <benoit.lobreau@dalibo.com>, Guillaume Lelarge <guillaume.lelarge@dalibo.com>, Pierrick Chovelon <pierrick.chovelon@dalibo.com>
Date: 2025-09-18T06:53:47Z
Lists: pgsql-hackers 
On Wed, Sep 17, 2025 at 10:52:31AM -0500, Sami Imseih wrote:
> > One argument for keeping the tests would be that they nicely bring together the side-effect (logging) and these use-cases, whereas in the code they're pretty distant, making the connection not obvious.
> 
> Another argument is that we have no coverage on temp logging, which
> is why this bug was discovered. There are likely plenty of tools
> out there, for example pgbadger or manual log analysis, that
> have probably misinterpreted temporary usage all this time,
> because of the way the data was emitted.

Perhaps this is a sign that there is no need to be really aggressive
with backpatching aanything, as well.  At least that's my impression.
--
Michael

Commits

  1. Drop unnamed portal immediately after execution to completion

  2. Override log_error_verbosity to "default" in test 009_log_temp_files

  3. Add tests for logging of temporary file removal and statement