Re: More business with $Test::Builder::Level in the TAP tests
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>,
Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-06T08:24:29Z
Lists: pgsql-hackers
On 06.10.21 08:28, Michael Paquier wrote: > Following up with Peter E's recent commit 73aa5e0 to add some > forgotten level incrementations, I got to look again at what I did > wrong and why this stuff is useful. > > I have gone through all the TAP tests and any code paths using > subroutines, to note that we could improve the locations of the > reports we get by adding more $Test::Builder::Level. The context is > important, as some code paths use rather-long routines and also > argument values that allow to track easily which test path is being > taken (like pg_rewind), so there is no need to add anything in such > places. The attached patch adds incrementations for the tests where > the debugging becomes much easier if there is a failure. These look correct to me.
Commits
-
Add more $Test::Builder::Level in the TAP tests
- d5ab331a339d 12.9 landed
- bab0ff2e44b7 13.5 landed
- d834ebcf2320 14.1 landed
- f9c4cb686800 15.0 landed
-
Add missing $Test::Builder::Level settings
- 73aa5e0cafd0 15.0 cited