Re: BUG #16931: source code problem about commit_ts

Fujii Masao <masao.fujii@oss.nttdata.com>

From: Fujii Masao <masao.fujii@oss.nttdata.com>

To: Alvaro Herrera <alvherre@alvh.no-ip.org>

Cc: zoulx1982@163.com, pgsql-bugs@lists.postgresql.org

Date: 2021-04-11T15:09:45Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove leftover dead code from commit_ts.h.
- c84698ceaea8 19 (unreleased) landed
Remove COMMIT_TS_SETTS record.
- 08aa89b32626 14.0 landed
Fix bug in WAL replay of COMMIT_TS_SETTS record.
- c29bab799c82 9.6.22 landed
- d544671f1572 10.17 landed
- 09cb8512ff11 11.12 landed
- 73cce168ffcb 12.7 landed
- 092c077c1321 13.3 landed
- 438fc4a39c39 14.0 landed


On 2021/04/10 7:42, Alvaro Herrera wrote:
> On 2021-Mar-24, Fujii Masao wrote:
> 
>> diff --git a/src/backend/access/rmgrdesc/committsdesc.c b/src/backend/access/rmgrdesc/committsdesc.c
>> index 7ebd3d35ef..26bad44b96 100644
>> --- a/src/backend/access/rmgrdesc/committsdesc.c
>> +++ b/src/backend/access/rmgrdesc/committsdesc.c
>> @@ -38,31 +38,6 @@ commit_ts_desc(StringInfo buf, XLogReaderState *record)
>>   		appendStringInfo(buf, "pageno %d, oldestXid %u",
>>   						 trunc->pageno, trunc->oldestXid);
>>   	}
>> -	else if (info == COMMIT_TS_SETTS)
> 
> You have not pushed this one, right?  I think we should do it now.

Thanks for the ping! Pushed!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION