Re: Make all Perl warnings fatal

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: Anton Voloshin <a.voloshin@postgrespro.ru>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Michael Paquier <michael@paquier.xyz>, Alexander Korotkov <akorotkov@postgresql.org>

Date: 2024-10-29T09:34:09Z

Lists: pgsql-hackers

On 22.10.24 11:25, Anton Voloshin wrote:
> Hello,
> 
> On 18/01/2024 10:52, Peter Eisentraut wrote:
>  > Committed, thanks.
> 
> since this patch two .pl files without FATAL in "use warnings" have been 
> committed to master:
> src/test/recovery/t/043_wal_replay_wait.pl
> src/test/modules/test_misc/t/006_signal_autovacuum.pl
> 
> They come from
> commit 06c418e163e913966e17cb2d3fb1c5f8a8d58308
> Author: Alexander Korotkov <akorotkov@postgresql.org>
> Date:   Tue Apr 2 22:48:03 2024
> 
>      Implement pg_wal_replay_wait() stored procedure
> 
> and
> 
> commit d2b74882cab84b9f4fdce0f2f32e892ba9164f5c
> Author: Michael Paquier <michael@paquier.xyz>
> Date:   Tue Jul 16 04:05:46 2024
> 
>      Add tap test for pg_signal_autovacuum role
> 
> An obvious patch adding FATAL => 'all' is attached.

Thanks, I committed the rest of this.

Commits

Add missing FATAL => 'all' to a use warnings in Perl
- 014720c6d9fb 18.0 landed
Make all Perl warnings fatal in 043_wal_replay_wait.pl
- e1555645d729 18.0 landed
Add tap test for pg_signal_autovacuum role
- d2b74882cab8 18.0 cited
Implement pg_wal_replay_wait() stored procedure
- 06c418e163e9 17.0 cited
Fix an issue in PostgreSQL::Test::Cluster:psql()
- 686db12de3a0 17.0 landed
Make all Perl warnings fatal
- c5385929593d 17.0 landed
Fix a warning in Perl test code
- a7ebd82b9e50 17.0 landed
Avoid use of Perl getprotobyname
- 01226c682ce6 17.0 landed