Re: RFC: Allow EXPLAIN to Output Page Fault Information

On 2026-01-25 23:35, Jelte Fennema-Nio wrote:

> On Tue Oct 28, 2025 at 9:43 AM CET, torikoshia wrote:
>> Rebased the patch again.
> 
> I took another look at this patch because I think it would be really
> useful to have. Below is my review:

Thank you for the review!

> 8. Now that worker is the default io_method the new explain fields are 
> never
>    present in the explain tests anymore. So explain_1.out is
>    unnecessary and can be removed. That obviously also means that
>    there's no coverage for this feature at all in the tests currently,
>    which is clearly a problem. So I think it would be good to add some
>    actual tests for the feature using some other io_method in a Perl 
> TAP
>    test.

However, I noticed that there are test environments where io_method is 
set to io_uring (for example, Linux Debian Trixie builds on Cirrus CI 
using Meson), so it appears that explain_1.out is still needed.
Given this, adding the Perl TAP test might be somewhat redundant, but 
for now I’m attaching a patch that includes both.

> 9. The added docs about the kernel not being built with the correct
>    options seems a bit too much detail. I'd say remove that sentence.
>    And maybe shorten th

Is this comment still a work in progress?

I agree with the other comments. Attached an updated patch reflecting 
them.


Regards,

--
Atsushi Torikoshi
Seconded from NTT DATA Japan Corporation to SRA OSS K.K