Horton

Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly

Alexander Law <exclusion@gmail.com>

View thread View on postgr.es
From: Alexander Lakhin <exclusion@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-bugs@lists.postgresql.org
Date: 2019-08-07T04:12:48Z
Lists: pgsql-bugs

Attachments

Hello Michael,
06.08.2019 9:21, Michael Paquier wrote:
> On Mon, Aug 05, 2019 at 08:55:55AM +0300, Alexander Lakhin wrote:
>> In case this bug is worth fixing, please look at the improved patch with
>> the corresponding regression test.
> In this case, DecodeSpecial() decodes the abbrevation passed down as
> UNITS, which is right on its own.  Still, afterwards the code fails to
> correctly set a date from the string present.  In short, your
> suggestion of fix looks good to me and that's more consistent with the
> full timezone spec case.  The test case you added in this patch
> triggers the error in the code path where the timezone is not
> specified.  Could you add an extra test case for the timezone
> abbreviation?
Sure, please look at the improved fix.

Best regards,
Alexander

Commits

  1. Fix some incorrect parsing of time with time zone strings