Re: make world and install-world without docs
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-07-01T19:39:16Z
Lists: pgsql-hackers
On 01.07.21 16:47, Andrew Dunstan wrote: > > On 6/2/21 4:21 PM, Tom Lane wrote: >> Andrew Dunstan <andrew@dunslane.net> writes: >>> I'm inclined to agree with Alvaro that the messages are at best an >>> oddity. Standard Unix practice is to be silent on success. >> We've been steadily moving towards less chatter during builds. >> I'd be good with dropping these messages in HEAD, but doing so >> in the back branches might be inadvisable. > OK, I think on reflection new targets will be cleaner. What I suggest is > the attached, applied to all branches, followed by removal of the four > noise messages in just HEAD. This naming approach is a bit problematic. For example, we have "install-bin" in src/backend/, which is specifically for only installing binaries, not data files etc. (hence the name). Your proposal would confuse this scheme. I think we should also take a step back here and consider: We had "all", which wasn't "all" enough, then we had "world", now we have "world-minus-a-bit", but it's still more than "all". It's like we are trying to prove the continuum hypothesis here. I think we had consensus on the make variable approach, so I'm confused why a different solution was committed and backpatched without discussion.
Commits
-
Add new make targets world-bin and install-world-bin
- 100e9ae53f21 14.0 landed
- b8c4261e5e8d 15.0 landed
- cbd5d7c852dc 9.6.23 landed
- b796435be003 10.18 landed
- a7e3a390e11e 11.13 landed
- c71471c96f16 12.8 landed
- bd0be7f7a42f 13.4 landed