Horton

Re: heapgettup refactoring

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2023-01-02T10:22:57Z
Lists: pgsql-hackers 
On 30.11.22 23:34, Melanie Plageman wrote:
> I have attached a patchset with only the code changes contained in the
> previous patch 0003. I have broken the refactoring down into many
> smaller pieces for ease of review.

To keep this moving along a bit, I have committed your 0002, which I 
think is a nice little improvement on its own.

Commits

  1. Remove stray duplicated comment in heapam.h

  2. More refactoring of heapgettup() and heapgettup_pagemode()

  3. Run pgindent on heapam.c

  4. Push lpp variable closer to usage in heapgetpage()

  5. Variable renaming in preparation for refactoring

  6. Turn HeapKeyTest macro into inline function

  7. Remove unused include

  8. Remove redundant breaks in HeapTupleSatisfiesVisibility