remove some STATUS_* symbols
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-12-29T10:33:34Z
Lists: pgsql-hackers
Attachments
- 0001-Remove-STATUS_FOUND.patch (text/plain) patch 0001
- 0002-Remove-STATUS_WAITING.patch (text/plain) patch 0002
I have found the collection of STATUS_* defines in c.h a bit curious. There used to be a lot more even that have been removed over time. Currently, STATUS_FOUND and STATUS_WAITING are only used in one group of functions each, so perhaps it would make more sense to remove these from the global namespace and make them a local concern. Attached are two patches to remove these two symbols. STATUS_FOUND can be replaced by a simple bool. STATUS_WAITING is replaced by a separate enum. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Remove STATUS_WAITING
- a513f1dfbf2c 14.0 landed
-
Remove STATUS_FOUND
- c096a804d9dc 13.0 landed