Re: CURRENT OF causes an error when IndexOnlyScan is used
Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: pgsql-hackers@lists.postgresql.org
Date: 2018-02-21T14:33:55Z
Lists: pgsql-hackers
Attachments
- return_heaptuple_in_btree_indexonlyscan_v2.patch (text/x-patch) patch v2
20.02.2018 12:52, Aleksander Alekseev: > Hi Anastasia, > >> I'd like to propose the patch that fixes the issue. >> We already have a way to return heaptuple from IndexOnlyScan, >> but it was not applied to b-tree for some reason. >> >> Attached patch solves the reported bug. >> Moreover, it will come in handy for "index with included attributes" feature >> [1], >> where we can store long (and even TOASTed) attributes in indextuple. >> >> [1] https://commitfest.postgresql.org/17/1350/ > I believe the patch should include a test that tries to reproduce an > issue it tries to fix. > > Also maybe this code that repeats 3 times can be moved to a separate > procedure? Good point. Updated version with test is attached. -- Anastasia Lubennikova Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
Commits
-
Fix WHERE CURRENT OF when the referenced cursor uses an index-only scan.
- 8f5ac440430a 11.0 landed
- ee7bf0fd9fa7 10.4 landed
- 7de7ddb27a86 9.5.13 landed
- 5b77c11da24a 9.3.23 landed
- 12d18b4870a2 9.6.9 landed
- 0a0721f84c40 9.4.18 landed