Re: pg_waldump and PREPARE

btkimurayuzk <btkimurayuzk@oss.nttdata.com>

From: btkimurayuzk <btkimurayuzk@oss.nttdata.com>

To: Fujii Masao <masao.fujii@gmail.com>

Cc: Andrey Lepikhov <a.lepikhov@postgrespro.ru>, Michael Paquier <michael@paquier.xyz>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Thomas Munro <thomas.munro@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, vignesh C <vignesh21@gmail.com>

Date: 2019-11-20T07:16:45Z

Lists: pgsql-hackers

Attachments

modify_xl_xact_relfilenodes_attr_comment.patch (text/x-diff) patch

>> I did not see any problems in this version of the patch. The 
>> information
>> displayed by pg_waldump for the PREPARE record is sufficient for use.
> 
> Thanks Andrey and Michael for the review! I committed the patch.
> 
> Regards,


Hi,
There is a mistake in the comment in the definition of 
xl_xact_relfilenodes.
This is a small patch to correct it.

Regards,

Yu Kimura

Commits

Fix comment in xact.h
- f9cb8bd3f217 13.0 landed
Make pg_waldump report more detail information about PREPARE TRANSACTION record.
- 7b8a899bdeb6 13.0 landed
Store 2PC GID in commit/abort WAL recs for logical decoding
- 1eb6d6527aae 11.0 cited