Horton

Thread

Commits

  1. Move NON_EXEC_STATIC from c.h to postgres.h

  1. Move NON_EXEC_STATIC from c.h

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2022-08-16T11:23:27Z

    Looking to tidy up c.h a bit, I think the NON_EXEC_STATIC #define 
doesn't need to be known globally, and it's not related to establishing 
a portable C environment, so I propose to move it to a more localized 
header, such as postmaster.h, as in the attached patch.

  2. Re: Move NON_EXEC_STATIC from c.h

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-08-16T13:50:23Z

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> Looking to tidy up c.h a bit, I think the NON_EXEC_STATIC #define 
> doesn't need to be known globally, and it's not related to establishing 
> a portable C environment, so I propose to move it to a more localized 
> header, such as postmaster.h, as in the attached patch.

Hmm, postgres.h seems like a better choice, since in principle any
backend file might need this.  This arrangement could require
postmaster.h to be included just for this macro.

Also, the macro was severely underdocumented already, and I don't
find "no comment at all" to be better.  Can't we afford a couple
of lines of explanation?

			regards, tom lane

  3. Re: Move NON_EXEC_STATIC from c.h

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2022-08-23T19:13:20Z

    On 16.08.22 15:50, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>> Looking to tidy up c.h a bit, I think the NON_EXEC_STATIC #define
>> doesn't need to be known globally, and it's not related to establishing
>> a portable C environment, so I propose to move it to a more localized
>> header, such as postmaster.h, as in the attached patch.
> 
> Hmm, postgres.h seems like a better choice, since in principle any
> backend file might need this.  This arrangement could require
> postmaster.h to be included just for this macro.

I picked postmaster.h because the other side of the code, where the 
no-longer-static symbols are used, is in postmaster.c.  But postgres.h 
is also ok.

> Also, the macro was severely underdocumented already, and I don't
> find "no comment at all" to be better.  Can't we afford a couple
> of lines of explanation?

Here is a new patch with more comments.

  4. Re: Move NON_EXEC_STATIC from c.h

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-08-23T21:06:00Z

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> Here is a new patch with more comments.

LGTM

			regards, tom lane