Re: Building with meson on NixOS/nixpkgs

Wolfgang Walther <walther@technowledgy.de>

From: Wolfgang Walther <walther@technowledgy.de>

To: Tristan Partin <tristan@partin.io>, Andres Freund <andres@anarazel.de>, Heikki Linnakangas <hlinnaka@iki.fi>

Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2024-08-17T21:24:43Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Support falling back to non-preferred readline implementation with meson
- 1091f8e0a48b 16.4 landed
- ed9d04463200 17.0 landed
- 67427f10093a 18.0 landed
Support absolute bindir/libdir in regression tests with meson
- 7f61882b638a 16.4 landed
- eb6765d57cfa 17.0 landed
- ff34ae368bdb 18.0 landed
Fallback to clang in PATH with meson
- 23be5206327c 16.4 landed
- a32ffeebfa63 17.0 landed
- 4d8de281b583 18.0 landed
Fallback to uuid for ossp-uuid with meson
- cc90d7823a6e 16.4 landed
- 469b97c52413 17.0 landed
- a00fae9d43e5 18.0 landed
meson: Add support for detecting ossp-uuid without pkg-config
- 2416fdb3ee30 18.0 cited

Tristan Partin:
> On Fri Aug 9, 2024 at 11:14 AM CDT, Andres Freund wrote:
> [..]
>> commit a00fae9d43e5adabc56e64a4df6d332062666501
>> Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
>> Date:   2024-07-27 13:53:08 +0300
>>
>>     Fallback to uuid for ossp-uuid with meson
>> [..]
>>
>> I think this is a redundant change with
>>
>> commit 2416fdb3ee30bdd2810408f93f14d47bff840fea
>> Author: Andres Freund <andres@anarazel.de>
>> Date:   2024-07-20 13:51:08 -0700
>>
>>     meson: Add support for detecting ossp-uuid without pkg-config
>> [..]
> 
> I'm not sure I would call them redundant. It's cheaper (and better) to 
> do a pkg-config lookup than it is to do the various checks in your 
> patch. I think the two patches are complementary. Yours services Windows 
> plus anywhere else that doesn't have a pkg-config file, while Wolfgang's 
> services distros that install the pkg-config with a different name.

Agreed.

There is also a small difference in output for meson: When uuid is 
queried via pkg-config, meson also detects the version, so I get this 
output:

   External libraries
[..]
     uuid                   : YES 1.6.2


Without pkg-config:

   External libraries
[..]
     uuid                   : YES

Best,

Wolfgang