Re: REINDEX SCHEMA/DATABASE/SYSTEM weak with dropped relations

Anastasia Lubennikova <a.lubennikova@postgrespro.ru>

From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-09-01T10:25:27Z
Lists: pgsql-hackers
On 01.09.2020 04:38, Michael Paquier wrote:
> I have added some extra comments.  There is one in
> ReindexRelationConcurrently() to mention that there should be no extra
> use of MISSING_OK once the list of indexes is built as session locks
> are taken where needed.
Great, it took me a moment to understand the logic around index list 
check at first pass.
> Does the version attached look fine to you?  I have done one round of
> indentation while on it.

Yes, this version is good.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company




Commits

  1. Fix thinko with definition of REINDEXOPT_MISSING_OK

  2. Improve handling of dropped relations for REINDEX DATABASE/SCHEMA/SYSTEM