Re: executor relation handling

Jesper Pedersen <jesper.pedersen@redhat.com>

From: Jesper Pedersen <jesper.pedersen@redhat.com>

To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Amit Langote <amitlangote09@gmail.com>

Cc: David Rowley <david.rowley@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>

Date: 2018-09-13T11:27:45Z

Lists: pgsql-hackers

Hi Amit,

On 9/13/18 12:58 AM, Amit Langote wrote:
> Attached updated patches.
> 
> Beside the issue that caused eval-plan-qual isolation test to crash, I
> also spotted and fixed an oversight in the 0002 patch which would lead to
> EState.es_output_cid being set to wrong value and causing unexpected error
> during tuple locking as result of that.
> 

Thanks for the update.

However, the subscription TAP test 
(src/test/subscription/t/001_rep_changes.pl) is still failing.

CFBot has the same log

  https://travis-ci.org/postgresql-cfbot/postgresql/builds/427999969

as locally.

Best regards,
  Jesper

Commits

Avoid O(N^2) cost in ExecFindRowMark().
- f9eb7c14b08d 12.0 landed
Remove some unnecessary fields from Plan trees.
- 52ed730d511b 12.0 landed
Restore sane locking behavior during parallel query.
- 29ef2b310da9 12.0 landed
Remove more redundant relation locking during executor startup.
- f2343653f5b2 12.0 landed
In the executor, use an array of pointers to access the rangetable.
- d73f4c74dd34 12.0 landed
Centralize executor's opening/closing of Relations for rangetable entries.
- 9ddef36278a9 12.0 landed
Change executor to just Assert that table locks were already obtained.
- 9a3cebeaa7fd 12.0 landed
Change rewriter/planner/executor/plancache to depend on RTE rellockmode.
- 6e35939febf8 12.0 landed
Add assertions that we hold some relevant lock during relation open.
- b04aeb0a053e 12.0 landed
Create an RTE field to record the query's lock mode for each relation.
- fdba460a26af 12.0 landed