Re: A bug in mapping attributes in ATExecAttachPartition()

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>

To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>

Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Amit Langote <amitlangote09@gmail.com>

Date: 2017-06-12T07:49:18Z

Lists: pgsql-hackers

Attachments

0001-Fixes-around-partition-constraint-handling-when-atta.patch (text/plain) patch 0001

On 2017/06/09 20:47, Ashutosh Bapat wrote:
> Thanks for the long explanation. I guess, this should be written in
> comments somewhere in the code there. I see following comment in
> ATExecAttachPartition()
> --
>      *
>      * There is a case in which we cannot rely on just the result of the
>      * proof.
>      */
> 
> --
> 
> I guess, this comment should be expanded to explain what you wrote above.

Tried in the attached updated patch.

Thanks,
Amit

Commits

Fix inconsistent capitalization.
- 29f021160ea7 10.0 landed
- 42651bdd68a1 11.0 landed
Fix bug in deciding whether to scan newly-attached partition.
- f85f88bcc270 10.0 landed
Fix lock upgrade hazard in ATExecAttachPartition.
- 972b6ec20bf0 10.0 landed
Code beautification for ATExecAttachPartition.
- 583df3b5c562 10.0 landed
Teach predtest.c about CHECK clauses to fix partitioning bugs.
- b08df9cab777 10.0 landed
Don't explicitly mark range partitioning columns NOT NULL.
- 3ec76ff1f2cf 10.0 cited