Horton

Re: New standby_slot_names GUC in PG 17

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Bruce Momjian <bruce@momjian.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-06-26T19:32:27Z
Lists: pgsql-hackers 
On 21.06.24 17:37, Bruce Momjian wrote:
> The release notes have this item:
> 
> 	Allow specification of physical standbys that must be synchronized
> 	before they are visible to subscribers (Hou Zhijie, Shveta Malik)
> 
> 	The new server variable is standby_slot_names.
> 
> Is standby_slot_names an accurate name for this GUC?  It seems too
> generic.

This was possibly inspired by pg_failover_slots.standby_slot_names 
(which in turn came from pglogical.standby_slot_names).  In those cases, 
you have some more context from the extension prefix.

The new suggested names sound good to me.

Commits

  1. Update release notes to reflect recent commit 0f934b0739.

  2. Rename standby_slot_names to synchronized_standby_slots.

  3. Add a new slot sync worker to synchronize logical slots.