Re: TEMP_CONFIG vs test_aio

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>

To: Andres Freund <andres@anarazel.de>

Cc: Todd Cook <cookt@blackduck.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Noah Misch <noah@leadboat.com>

Date: 2025-04-02T12:34:11Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

tests: Cope with io_method in TEMP_CONFIG in test_aio
- 327d987df1e7 18.0 landed
aio: Add test_aio module
- 93bc3d75d8e1 18.0 cited

On 2025-04-01 Tu 5:34 PM, Andres Freund wrote:
> Hi,
>
> On 2025-04-01 17:08:49 -0400, Andrew Dunstan wrote:
>> On 2025-04-01 Tu 4:17 PM, Andres Freund wrote:
>>> For one using PG_TEST_INITDB_EXTRA_OPTS would probably require changing the
>>> buildfarm code, because the buildfarm code filters out environment variables
>>> that aren't on an allowlist (I really dislike that).
>>
>> Uh, not quite. Anything in the config's build_env is not filtered out. That
>> change was made a year ago.
> Huh. Just recently I tried to configure PG_TEST_TIMEOUT_DEFAULT in build_env
> and did not take effect until I explicitly added it to the @safe_set.
>


Correction: the code changed was a year ago, bit it was in release 18, 
which was in November. If it didn't work after that I want to know.


This is the commit: 
https://github.com/PGBuildFarm/client-code/commit/e2dd43915b4aa97447a5e8118f733b444896db81


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com