Horton

Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <rhaas@postgresql.org>, pgsql-committers@lists.postgresql.org
Date: 2022-04-22T14:24:27Z
Lists: pgsql-hackers 
On 2022-04-22 Fr 10:04, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> This has upset the buildfarm's msys2 animals. There appears to be some
>> wildcard expansion going on that causes the problem. I don't know why it
>> should here when it's not causing trouble elsewhere. I have tried
>> changing the way the tests are quoted, without success. Likewise,
>> setting SHELLOPTS=noglob didn't work.
>> At this stage I'm fresh out of ideas to fix it. It's also quite possible
>> that my diagnosis is wrong.
> When I was looking at this patch, I thought the number of test cases
> was very substantially out of line anyway.  I suggest that rather
> than investing a bunch of brain cells trying to work around this,
> we just remove the failing test cases.

WFM.


cheers


andrew



--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Inhibit mingw CRT's auto-globbing of command line arguments

  2. Remove some recently-added pg_dump test cases.

  3. Allow db.schema.table patterns, but complain about random garbage.

  4. In PostgresNode.pm, don't pass SQL to psql on the command line

  5. Factor pattern-construction logic out of processSQLNamePattern.