Horton

Thread

Commits

  1. Format list of catalog files in makefile vertically

  1. Format list of catalog files in makefile vertically

    Peter Eisentraut <peter@eisentraut.org> — 2023-08-25T13:12:51Z

    I propose to reformat the catalog lists in src/backend/catalog/Makefile 
to be more vertical, one per line.  This makes it easier to keep that 
list in sync with src/include/catalog/meson.build, and visually compare 
both lists.  Also, it's easier to read and edit in general.

In passing, I'd also copy over some relevant comments from the makefile 
to meson.build.  For the hypothetical future when we delete the 
makefiles, these comments seem worth keeping.  (For fun, I tested 
whether the comments are still true, and yes, the order still matters.)

  2. Re: Format list of catalog files in makefile vertically

    Andres Freund <andres@anarazel.de> — 2023-08-25T13:25:22Z

    Hi, 

On August 25, 2023 9:12:51 AM EDT, Peter Eisentraut <peter@eisentraut.org> wrote:
>I propose to reformat the catalog lists in src/backend/catalog/Makefile to be more vertical, one per line.  This makes it easier to keep that list in sync with src/include/catalog/meson.build, and visually compare both lists.  Also, it's easier to read and edit in general.
>
>In passing, I'd also copy over some relevant comments from the makefile to meson.build.  For the hypothetical future when we delete the makefiles, these comments seem worth keeping.  (For fun, I tested whether the comments are still true, and yes, the order still matters.)

Makes sense to me.

Andres 
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

  3. Re: Format list of catalog files in makefile vertically

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2023-08-26T16:38:15Z

    On 2023-Aug-25, Peter Eisentraut wrote:

> I propose to reformat the catalog lists in src/backend/catalog/Makefile to
> be more vertical, one per line.  This makes it easier to keep that list in
> sync with src/include/catalog/meson.build, and visually compare both lists.
> Also, it's easier to read and edit in general.

+1

> In passing, I'd also copy over some relevant comments from the makefile to
> meson.build.  For the hypothetical future when we delete the makefiles,
> these comments seem worth keeping.  (For fun, I tested whether the comments
> are still true, and yes, the order still matters.)

Sure.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La experiencia nos dice que el hombre peló millones de veces las patatas,
pero era forzoso admitir la posibilidad de que en un caso entre millones,
las patatas pelarían al hombre" (Ijon Tichy)