Horton

Re: fix pg_mkdir_p to tolerate concurrent directory creation

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-18T16:56:25Z
Lists: pgsql-hackers 
On 2026-06-18 Th 11:43 AM, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net> writes:
>> Oh, good catch, thanks! Here's a revised patch.
> The Unix side of this LGTM.  I have no idea about the Windows
> half (... but are we sure GetFileAttributes() can't change errno?)
>
> 			


I'm told it does not. Google says:


GetFileAttributes does not set errno. Because it is a Win32 API function 
rather than a standard C library function, it sets the thread-local 
Last-Error Code instead.


|
|

|cheers|

|
|

|andrew|


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

  1. Make pg_mkdir_p() tolerant of a concurrent directory creation.