Horton

Re: Remove MSVC scripts from the tree

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Andrew Dunstan <andrew@dunslane.net>, Robert Haas <robertmhaas@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-21T07:31:57Z
Lists: pgsql-hackers 
On 20.12.23 18:22, Andrew Dunstan wrote:
> 
> On 2023-12-20 We 11:32, Robert Haas wrote:
>> On Wed, Dec 20, 2023 at 11:03 AM Andrew Dunstan <andrew@dunslane.net> 
>> wrote:
>>>> This could perhaps be related to this patch removing the module in
>>>> src/tools/msvc/dummylib/Win32/Registry.pm ?
>>> It is. I've fixed the buildfarm to stop checking this script.
>> Thanks! But I wonder whether the script itself also needs to be
>> changed? Are we expecting that the 'use Win32::Registry' in
>> win32tzlist.pl would be satisfied externally in some case?
>>
> 
> Yes, the module will normally be present on a Windows perl. The only 
> reason we had dummylib was so we could check the perl scripts on Unix.

But this use case still exists.  Right now, running

     ./src/tools/perlcheck/pgperlsyncheck .

fails because this module is missing.  So I think we need to put the 
dummy module back somehow.

Commits

  1. Make win32tzlist.pl checkable again

  2. meson: Make gzip and tar optional

  3. meson: Make sed optional

  4. Remove MSVC scripts

  5. Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl